Process for aliases, auto-connections and tracks

store-requests
1

Definitions

  • Reviewers are in the @reviewers forum group
  • Architects are those responsible for the design of snapd.
  • Votes are in favor (+1), against (-1), abstain (+0)
  • Voting period is one week
  • Voting period extension is 3 days

Process

  1. Requester creates a forum post in the store-requests category and makes case for change. To disambiguate snaps, the requester should either give the store URL for the snap or give the name and publisher of the snap. Voting period starts at time of request.
  2. Requester may not vote on his/her own snap.
  3. Reviewers and/or architects vote using the voting procedure (see below). Each vote should include a short rationale for the cast vote (longer rationale is required for voting contrary to an established pattern)
  4. If after voting period there are not enough votes based on voting procedure, a voting period extension should be requested by a reviewer/architect. The extension starts the day of the request for extension
  5. At the end of the voting period, a reviewer/architects tallies the results from the voting period (and extension), summarizes in the forum post and performs any necessary actions.

Voting procedure

  • The voting procedure is the same for granting and revoking auto-connections, auto-aliases and track requests.
  • If reviewers and up to at most one architect voted: simple majority with at least 2 votes in favor at end of voting period/extension: perform requested action. In the event of a tie, request more votes.
  • If two or more votes in favor/against from architects: reviewers votes are not tallied. If have only in favor votes from architects at end of voting period/extension: perform requested action, otherwise architects discuss until no against votes and at least one vote in favor from architects. If clear direction from architects, an architect may request the vote be tallied early.

alias request considerations

Granting aliases requires trust in the snap’s publisher and reasonable names for the aliases (eg, shouldn’t request an alias for something that is a widely known command of other software).

An alias should not be granted for the snap’s name since snapd already grants use of this name to the snap (eg, a snap named ‘foo’ with command ‘foo.foo2’ should not be granted the ‘foo’ alias, instead, the snap can rename the ‘foo2’ command to be ‘foo’ instead (and optionally request an alias for the ‘foo2’ command)).

auto-connection request considerations

In the snap ecosystem it is important to remember that there are several voices when considering auto-connection: snapd (base declaration policy), the gadget snap (for device-specific auto-connections, which does not apply to auto-connection requests), the store (snap declaration policy; ie, requests using this process) and the user.

For each snap interface, a determination is made for whether or not the interface should be manual or automatically connected based on a variety of criteria (the rationale is often in the snapd code base or pull requests) and this is codified in the base declaration.

A snap’s publisher may request that a normally manually-connected interface be auto-connected for a particular snap in the global, public store using the process outlined in this topic (brand store owners may grant auto-connections as appropriate for their brand). Granting auto-connection in the global, public store effectually means that the store is vouching for the publisher’s intent (maintenance, security updates, etc) and snap implementation (it does what it advertises, works well, etc) to the degree that the user’s initial choice on connection at install time is removed (the user may of course disconnect the interface after installation).

Reviewers must therefore consider various criteria to inform their vote on whether the request will be granted. Some of this criteria might include:

  • The “officialness” of the publisher of the snap
  • The “reasonableness” of the request. Eg, a “top-like” program will necessarily need the “system-observe” interface but not “network-control”
  • The snap name makes it clear that an interface should be auto-connected. Eg, a snap named “webcam” with it declaring the “camera” interface
  • The software is intended to be used by children
  • The sensitivity of the access relative to the “user’s voice” (see above)

For some interfaces there are patterns and rationale that can generally be applied. Please note the rationale is subject to change based on security concerns from the community (users, publishers, reviewers, snapd developers, etc), more appropriate technologies becoming available, new information and/or critical thinking, etc. Each request will be reviewed on its own merits and prior granting of auto-connection may be rescinded based on this new information.

  • alsa - auto-connection is generally limited to snaps requiring low-level, direct access to audio devices.
    • Rationale: a lot of hardware does not perform multiplexing of clients so a snap directly accessing the hardware might block audio for other applications on some systems. Sound servers like pulseaudio are designed to multiplex audio and snaps should typically instead plugs the audio-playback (and audio-record if needed), which grants access to pulseaudio
    • Reference: The alsa interface
  • content - the base declaration defines that snaps that plugs the content interface will auto-connect with other snaps from the same publisher. Global auto-connect for content providers is allowed only under certain circumstances
  • content for theme snaps - in addition to the above considerations, eventually snapd might suggest or auto-install theme snaps based on various criteria. Until review-tools checks are fully in place, if a publisher requests global auto-connection with greedy plugs, reviewers should:
  • cups-control - auto-connection is limited to snaps whose core functionality is printing or design programs where printing is an expected part of the workflow. Granting requires a stated commitment from the developer that moving to a safer API will be performed (such as the Printing portal) when it is widely available
  • joystick - auto-connection generally limited to game snaps
  • mpris - slot side is generally granted provided the name attribute makes sense for the snap. auto-connection of plugs is typically not auto-connected unless the slot’s publisher also agrees
  • password-manager-service - typically not auto-connected due to the sensitive nature of the access and because the user’s voice in this access is so important
    • Rationale: the various keyring services do not provide sufficient isolation for snap access to the interface to be auto-connected by default. Not only can the snap see all stored passwords, but all other applications with access to the password services can also see the snap’s passwords.
    • Reference: NordPass auto-connect to password-manager-service interface
  • removable-media: typically not auto-connected since the optional access to widely varied data does not outweigh the user’s voice regarding potentially sensitive data. Certain classes of applications may be granted an exception under certain circumstances.

    • Rationale: by definition data that is not always present (as is the case with removable-media) is optional access for typical snaps. All snaps with this interface connected have unrestricted access to all data from any plugged media. Considering that removable-media may contain sensitive documents, sensitive pictures/media, encryption keys, etc and that snapd has no insight on the nature of the data, the user’s voice with regard to connection is preserved

    • Exceptions: the following classes of applications may be considered for removable-media auto-connection:

      • major browsers and email clients (rationale: the software is designed with security and user privacy in mind)
      • media (eg, sound, photo, video) editors (rationale: the software is very often used to import/edit/export large files on external devices)
      • media (eg, sound, photo, video) players/viewers (rationale: the software is very often used to import/preview/playback files on external devices)
      • media (eg, sound, photo, video) recorders/cameras (rationale: the software is very often used to export/edit files on external devices)

      If the application falls into one of the above categories, then the following criteria will also be considered:

      • the application itself is a mature, well-known application
      • the snap’s (vetted) publisher is a mature, well-known entity
      • the snap’s (vetted) publisher is the upstream of the software
      • if the snap is published by someone other than upstream, the publisher must be vetted and either be an established committer to the upstream or the wider snap ecosystem (eg, an established well-known contributor to the software itself, a member of the snapcrafters group, etc)
        • if the publisher doesn’t meet these criteria, other options may or may not be considered such as the publisher joining snapcrafters, snapcrafters becoming a collaborator on the snap, auto-connection granted conditional on the snap packaging being accepted upstream, upstream stating they trust the publisher with the packaging, etc.

    • Additional information:

      • The removable-media interface is considered a ‘transitional’ interface since, when connected, only traditional UNIX permissions are considered for file access. This allows, for example, a service in a snap to setup inotify/etc to programmatically monitor and exfiltrate/modify files on external media in the background
      • Eventually, applications will either use safer APIs for file access (eg, like portals) or future snapd-prompting mechanisms may be available to obviate the need for auto-connecting this interface
      • Security-conscious users may want to remove sensitive external media when installing snaps, then disconnect the interface from those snaps to prevent them from having access
      • In the future, snapd may grow controls to disable certain interface auto-connections for interfaces like removable-media
  • uinput: typically not auto-connected because it allows injecting arbitrary input into the system. In addition, due to popular hardware/software instructions outside of the snap ecosystem, /dev/uinput may be world read and writable (default udev rules create it as root-owned with only root read and writable). Due to these considerations, publishers requesting use of (and especially auto-connect) should be vetted.

Manual connection mitigations

If auto-connection is not granted, options for snap publishers are:

  • have the snap check if the interface is connected via snapctl is-connected <iface> and instruct the user to use the snap connect CLI command or connect via the snap-store/gnome-software GUI. This could be done on startup or contextually at the time of access. Ideally when instructing the user, the details of the access would be explained so the user can make an informed choice. It is true that there is an extra step for the user, but done well, this need not be onerous and may even provide additional trust that your snap and the system as a whole are working to keep everything secure. Note, if using snapctl is-connected you should also add a corresponding assumes: 2.43 to your snapcraft.yaml since this is only available in snap since 2.43 to ensure this functions as expected.
  • use a newer, safer API. Eg, instead of using cups-control, the application could use the Printing portal. If an application needs access to a file from a disconnected interface/etc, use a file dialog that supports portals
  • fallback gracefully. Eg, if password-manager-service is disconnected, fallback to storing passwords locally

In the future, the snapd team plans to provide a prompt API for snaps to use that will not only provide appropriate messaging, but also allow the user to choose to connect within the prompt.

Finally, the desktop team has discussed the lack of isolation in secret-service with upstream GNOME and there are plans to improve the service (see ‘Active Attacks’) to provide the necessary isolation for auto-connecting. Hopefully, KDE/Plasma will follow with kwallet or move to the improved service.

Tracks

There is a simplified process for tracks for snaps with predictable cadence.

12 Likes
2

OTOH, I suggest that snappy architects and store reviewers get a vote such that:

  • if >= 2 +1s, grant after 1 week of initial request (to give architects, et al a chance to read)
  • if >= 2 +1s from architects, grant immediately regardless of number of reviewers’ -1s
  • if architects disagree, do nothing until they agree
  • reviewer may not vote on his/her own snap. An architect may vote on his/her own snap.

This should allow things to move ahead without needless red tape. If architects disagree at a later time, that is cause for re-discussion with the same voting procedure as above for revocation.

1 Like
3

After giving some thought on corner cases last night, here is a more formalized proposal:

  • reviewers are MyApps reviewers in Launchpad
  • snappy architects are Mark, Gustavo, etc
  • votes are in favor (+1), against (-1), abstain (+0)
  • voting period is one week
  • voting period extension is 3 days

Process:

  • a requester creates a forum post with the ‘store’ tag and makes case for change. To disambiguate snaps, the requester should either give the store URL for the snap or give the name and publisher of the snap. Voting period starts at time of request
  • a requester (reviewer or architect) may not vote on his/her own snap
  • reviewers and/or architects vote using the voting procedure (see below)
  • if after voting period there are not enough votes based on voting procedure, a voting period extension should be requested by a reviewer/architect. The extension starts the day of the request for extension
  • at the end of the voting period, a reviewer/architects tallies the results from the voting period (and extension), summarizes in the forum post and performs any necessary actions

Voting procedure:

  • the voting procedure is the same for granting and revoking auto-connections and auto-aliases
  • if reviewers and up to at most one architect voted: simple majority with at least 2 votes in favor at end of voting period/extension: perform requested action
  • if two or more votes in favor/against from architects: reviewers votes are not tallied. If have only in favor votes from architects at end of voting period/extension: perform requested action, otherwise architects discuss until no against votes and at least one vote in favor from architects. If clear direction from architects (eg, no abstain votes), an architect may request the vote be tallied early.
1 Like
4

Rationale and proposed process sounds like a great start, thanks for putting it in place Jamie.

As a minor addition, might be good to request the inclusion of a short rationale to back any positive or negative votes, so that others can comprehend the reason and correlate or not.

Then, as a trivial detail, store is actually a category in the forum rather than a tag.

1 Like
5

Thanks @niemeyer

Based on that, here are the approved procedures:

Alias and Auto-Connection request and approval process

Definitions

  • reviewers are MyApps reviewers in Launchpad
  • snappy architects are Mark, Gustavo, etc
  • votes are in favor (+1), against (-1), abstain (+0)
  • voting period is one week
  • voting period extension is 3 days

Process

  • a requester creates a forum post with the ‘store’ category and makes case for change. To disambiguate snaps, the requester should either give the store URL for the snap or give the name and publisher of the snap. Voting period starts at time of request
  • a requester (reviewer or architect) may not vote on his/her own snap
  • reviewers and/or architects vote using the voting procedure (see below). Each vote should include a short rationale for the cast vote
  • if after voting period there are not enough votes based on voting procedure, a voting period extension should be requested by a reviewer/architect. The extension starts the day of the request for extension
  • at the end of the voting period, a reviewer/architects tallies the results from the voting period (and extension), summarizes in the forum post and performs any necessary actions

Voting procedure

  • the voting procedure is the same for granting and revoking auto-connections and auto-aliases
  • if reviewers and up to at most one architect voted: simple majority with at least 2 votes in favor at end of voting period/extension: perform requested action
  • if two or more votes in favor/against from architects: reviewers votes are not tallied. If have only in favor votes from architects at end of voting period/extension: perform requested action, otherwise architects discuss until no against votes and at least one vote in favor from architects. If clear direction from architects (eg, no abstain votes), an architect may request the vote be tallied early.
2 Likes
6

@jdstrand Thanks for formatting it nicely. Would be nice to have that process as the first message of this topic, so people getting into it will see the actual approved process upfront.

1 Like
7

I’ve done this just now.

1 Like
8

One more request. Could the first message be updated to reflect the fact that this process also applies to track requests? So far I’ve been informally pointing people to this post and just saying “this also applies to tracks despite what the process specifies” but it’d be nice for that to be formalized.

Thanks!

2 Likes
9

FYI, I did this yesterday.

2 Likes
10

@jdstrand @niemeyer Is it possible that we can one or two people from CE into the list of reviewers to speed up reviews for certain commercial things?

2 Likes
11

It is of course possible; I’ll leave the decision to @niemeyer if we want to do this.

My question is what in the existing process is causing trouble? You asked on this thread and I saw in another thread you wanted to speed up the one week waiting period. The one week waiting period is in place so reviewers have a chance to vote (ie, we want to support the case where 2 quick ‘yea’ votes are cast and then a ‘nay’ vote later). There is also a process for architects to waive the waiting period. Is this not sufficient for your needs?

2 Likes
12

@morphis @jdstrand Everybody is welcome to review, but we need at least two reviews from people that are sitting here all the time and reviewing things all the time and that remain aware of current practices. Having someone sporadically reviewing and mainly when they want things in quickly feels like a recipe for bad reviews.

4 Likes
13

I’ve been meaning to investigate/document this for a while-- reviewers need not worry about granting an alias that is used by other snaps or an alias that is the name of a snap. snapd will prevent inconsistencies:

  • if a snap is installed with an alias, then installing a snap with the name of the alias (ie snap install <alias>) results in the snap being uninstallable until the alias is removed with snap unalias <alias>
  • if a snap is installed that has an automatic alias that matches the name of an already installed snap, then installing the snap with the alias results in the snap being uninstallable (this may be a bug, but it is safe)
  • if two snaps have an automatic alias with the same name, the second snap is not installable until the first’s alias is removed with snap unalias <alias>
1 Like
15

I have polished a bit the topic and moved it into the documentation category.

In the process, I’ve also removed @jdstrand’s historical problem description from the post itself.

Here is the content for posterity:

1 Like
17

So apparently myapps-reviewers is going away. In light of this, who are “reviewers” with regards to this topic?

2 Likes
18

The current ‘myapps-reviewers’ from LP are:

IMO, the new forum group/team should consist of these people.

3 Likes
19

I would like to ask if the @reviewers group really exist? Directly clicking on the tag gives an “Access Denied while trying to load /groups/reviewers.json” error.

1 Like
20

The group exists, yes. I’m able to see everyone in it by going to https://forum.snapcraft.io/groups/reviewers. You might have to be an admin to see it.

2 Likes
21

I would like to request pinning this topic in the store category, if that makes sense.

1 Like