Auto Connection Request For icon-theme-papirus Snap

store-requests
5

Ah ok, so you are asking for global auto-connect for your theme snap? Thanks. This needs a bit more indepth review since we have to assess the contents of the snap is as expected - see the content and content for theme snaps items on https://snapcraft.io/docs/process-for-aliases-auto-connections-and-tracks

6

Yes you got it right, i am providing the yaml too for review :–

7

For the snap to be suggested for installation by snapd-desktop-integration, then it would need to be named icon-theme-papirus. And that would only work for the Papirus, Papirus-Dark, and Papirus-Light themes (as they all have the “papirus” prefix).

We don’t currently have a way to present it as an auto-install candidate for the ePapirus and ePapirus-Dark themes unless they were split out into a separate icon-theme-epapirus package. Those icon themes would still be made available to other snaps with your current layout: the user would just need to manually install the snap if they’re using ePapirus.

I’d also suggest switching to the bare base for the snap. You can do this by replacing base: core22 with:

base: bare
build-base: core22

This way your snap won’t force the install of the core22 snap. As your snap is only providing image data, it doesn’t need a runtime of its own. This way you don’t need to worry that you’re the last snap requiring core22 when core24, core26, etc come out.

Lastly, consider making your snap architecture independent.

architectures:
  - build-on: amd64
    build-for: all

As it’s just data, the single snap will work on all architectures.

8

Thanks for the reply, i would like to know the way the snap can be renamed to the suggested one, i will implement the other changes in the meantime.

EDIT : Implemented all recommended changes other than renaming

9

There isn’t currently a method to rename snaps. You could just register the new name and publish there though. You’ve only just created the snap, so there aren’t likely many users around to migrate.

10

ok, so will i have to open other request for the new snap ??

11

Just edit the thread title and post to reflect the new snap name. It’s still essentially the same request.

12

Got it i have implemented all the suggestions provided, whats the next step

13

hey @review-team is my request completed ??

14

Each request needs two +1 votes from someone in @reviewers then it can be actioned. As I said earlier, icon-theme reviews are more in-depth since it involves inspecting the contents of the snap itself, so you will have to be patient. Thanks.

15

I have a quick question, @SamAlex are you a member of the Papirus team?

16

No just a community contribution, i have no contact with them though i requested them to make this offering official, no response from their side, i will retry ??, is it must for a official nod because i believe they are least interested in offering snap support, but i hope the best to get a nod from them if snapcrafters need a official nod

17

@Igor i have created contact with them, and some positive result are expected so we can consider the snap to be officially provided by papirus community in a short time ??

EDIT: The snap is now officially supported by the papirus community Hope this is enough…

18

Thanks for the clarification.

+1 from me, provided the check by the store team passes.

19

Hey @review-team , is this request completed ??, can i close this issue as completed…

20

No this is not completed - this issue will be updated when that is done.

21

So there are two main things here - since this is a content interface we need an assurance from the snap publisher that they will maintain a stable “API” for the content interface and hence won’t remove things from it etc which could then break other snaps which use the content interface.

The second thing is since this is using greedy plugs to ensure it is auto-connected to any plugging snap then we need to get some assurance that the snap is “safe” (ie that it doesn’t ship say a daemon or hook or any command etc, and to vet the publisher as well).

FYI - these are all detailed at Process for aliases, auto-connections and tracks under “content for theme snaps”.

Looking at the current papirus snap it only appears to contain image files etc and the snap yaml only declares the icon-themes slot as named above, there are no hooks/daemons/apps etc.

So this all looks good from my side, +1 from me.

The one remaining thing to do before granting this is publisher vetting - @Igor could you please take a look?

22

+1 from me, I verified the request with the upstream publisher.

23

@review-team is this done ??

24

+1 from me to use content interface named icon-themes with snap ships only (valid) content files.

+2 for, 0 against. Granting the use of content interface to icon-theme-papirus snap.

This is now live. thanks