Review request for lnav snap

store-requests
1

Hello, my snap (https://snapcraft.io/lnav/) seems to require a review for the addition of the system-files interface to read the “/etc/lnav” directory. The directory is used to store configuration files that are common to all users on a machine. The configuration files are used to define how to parse log files. This request was raised by a user here – https://github.com/tstack/lnav/issues/1166

Thanks,

Tim Stack

2

To aid in the review process, I have reproduced the specific system-files declaration from you snap.yaml here:

plugs:
  etc-lnav:
    interface: system-files
    read:
    - /etc/lnav

Since lnav is the clear owner of this path, it makes sense that the snap is able to read this configuration from the host if it already exists. +1 from me for use of and auto-connect of a system-files instance named etc-lnav for read access to /etc/lnav for the lnav snap.

3

Yes, +1 from me too. for the lnav snap to request read access (auto-connected) to /etc/lnav seems entirely reasonable. For awareness, this will be actioned at the end of the voting period as described here.

4

+2 votes for, 0 against. Granting lnav auto-connect of a system-files instance named etc-lnav for read access to /etc/lnav. This is now live.