Auto-connect interfaces + approval of Charmed-opensearch

store-requests privileged-interfaces
1

Hi - we are in the process of creating a new snap charmed-opensearch that’s based on the current opensearch snap.

This snap will essentially be:

  • opensearch snap code base + multiple additional opensearch plugins

The goal of this snap is to be tailored for our opensearch charm

Therefore, I’m requesting for all the interfaces as well their autoconnections that were approved for opensearch to be approved for charmed-opensearch.

Previous approval threads for context:

  • name: charmed-opensearch
  • description: snap for opensearch + multiple opensearch plugins (e.g: s3 / azure / hcs, prometheus exporter etc.)
  • snapcraft: snapcraft.yaml
  • upstream: upstream repository + other potential plugin repos
  • upstream-relation: This is a canonical snap
  • interfaces:
    • hardware-observe:
      • request-type: auto-connection
    • log-observe:
      • request-type: auto-connection
    • mount-observe:
      • request-type: auto-connection
    • system-observe:
      • request-type: auto-connection
    • shmem-perf-analyzer:
      • request-type: auto-connection
    • sys-fs-cgroup-service:
      • request-type: auto-connection
    • intel-qat:
      • request-type: auto-connection
    • process-control:
      • request-type: installation

Thank you,

Mehdi

2

This request has been added to the queue for review by the @reviewers team.

3

Hey @medib

The request looks fine in general. My only question is about shmem-perf-analyzer, if I understood correctly the original request the issue was solved using private shared memory (which should auto-connect by default). Is there any reason why private shared memory is not an option anymore?

Thanks

4

Hello @jslarraz - it’s fine as a private shmem, I copied all interfaces to make sure I don’t forget anything.

This request is really about mirroring everything granted to the opensearch charm - no addition / alteration needed.

Thanks, Mehdi

5

Thanks for clarifying. In that case, if I’m right the requested interfaces are:

  • hardware-observe:
    • request-type: auto-connection
  • log-observe:
    • request-type: auto-connection
  • mount-observe:
    • request-type: auto-connection
  • system-observe:
    • request-type: auto-connection
  • sys-fs-cgroup-service:
    • request-type: auto-connection
  • intel-qat:
    • request-type: auto-connection

These interface looks appropriate for charmed-opensearch and were already approved for the opensearch snap. Thus, +1 from for (#voteFor) granting auto-connection to the mentioned interfaces

6

@jslarraz thanks for replying.

process-control also needs to be approved for usage if I recall (not auto-connection), otherwise the snapstore upload will be rejected. If that’s not the case, we’re good with the list.

7

Unless I’m misinterpreting the base-declaration, it should be possible to install and manually connect process-control without any snap-declarition

8

Then it’s perfect, I was under the impression that an explicit approval was required for the store to approve the upload of a snap with that interface.

And for the rest of the interfaces, my understanding, is that I still need 1 approval, correct?

9

Right, we still need a second +1 before we can grant the requested permissions

1 Like
10

+1 (#voteFor) from me as well given the discussion above and the previously granted approvals for opensearch

11

Voting period has ended. This request is approved with 2 votes for and 0 votes against.

12

This is now live. New revisions uploaded to the store should now pass automatic review.