Tracks 18 & 20 request for nitrogen-gadget & nitrogen-kernel

gbisson · February 9, 2021, 9:37am

Dear @reviewers,
I would like to request the 18 and 20 tracks for the nitrogen-gadget and nitrogen-kernel snaps. so that I can maintain both versions, especially since gadget 18 & 20 versions really aren’t compatible.
Thanks in advance.

roadmr · February 9, 2021, 4:24pm

Hello,

Having tracks named after core revisions is a common pattern which is used when the snaps are for some reason dependent on features of a specific core version and cannot, for example, specify a different core in base:. Assuming that is the case with yours, +1 from me as reviewer to grant these two tracks.

We’ll allow a few days for other reviewers to comment, then I’ll review and ideally grant the tracks.

Daniel
Daniel

alexmurray · February 12, 2021, 7:18am

@gbisson Can you please comment on @roadmr’s question above re the need for these track names in respect to the corresponding core snaps?

gbisson · February 12, 2021, 8:06am

Hi,

Thanks for reviewing @alexmurray and @roadmr, indeed the nitrogen-gadget snap has a “base:” argument as you can see here:

github.com

boundarydevices/ubuntu-core/blob/18-arm64/gadget/meta/snap.yaml#L6


name: nitrogen-gadget
version: 18-1
summary: Nitrogen platforms support package
description: Support files for booting Boundary Devices Nitrogen platforms
type: gadget
base: core18
architectures:
    - arm64

However the nitrogen-kernel snap doesn’t, maybe I could do without the tracks BUT since it’s the kernel, I believe it would still be best to be able to keep the same version it was released with for the long term support. For instance, we’re currently using 5.4 kernel but are going to switch to the 5.10 kernel in the coming months, not sure how core16 or core18 will like this (different rules/apparmor version etc). If Canonical ensures previous core versions will work with newer Linux kernel I’m ok skipping the tracks.

Regards,
Gary

gbisson · February 12, 2021, 8:11am

FYI, seems like the pi-kernel is having 18/20 tracks:

You can see that each track uses a different version of the kernel, maybe for the reasons above. But I doubt the kernel yaml has a “base:” argument.

Regards,
Gary

gbisson · February 15, 2021, 3:35pm

Hi,
Actually I confirm the tracks for the kernel are needed due to initrd changes.
UC20 requires core20 initrd version:

github.com

ogra1/rockpi-n10-kernel/blob/master/snap/snapcraft.yaml#L49


  prime:
    - -toolchain
  after: [ firmware ]
kernel:
  plugin: kernel
  source: https://github.com/radxa/kernel.git
  source-depth: 1
  source-branch: rk3399pro-toybrick-stable
  kdefconfig: [ rockchip_linux_defconfig, snappy/generic.config, snappy/security.config, snappy/systemd.config, snappy/snappy.config, snappy/containers.config ]
  kernel-image-target: Image
  kernel-initrd-core-base: core20
  override-pull: |
    snapcraftctl pull
    set -e
    echo "applying snappy configs patches"
    git apply -v ../../../patches/configs.patch
    git apply -v ../../../patches/apparmor.patch
  override-build: |
    apt purge -y binutils-aarch64-linux-gnu cpp-9-aarch64-linux-gnu \
      cpp-aarch64-linux-gnu gcc-9-aarch64-linux-gnu \
      gcc-9-aarch64-linux-gnu-base gcc-aarch64-linux-gnu

Let me know if you need anything else for those tracks.
Regards,
Gary

roadmr · February 15, 2021, 4:21pm

thanks for the details. If any of the other @reviewers gives a +1 I can create these tracks

Daniel

ijohnson · February 15, 2021, 5:25pm

Just to confirm that at this time UC20 kernel snaps are not compatible with Ubuntu Core 18 and vice versa, so having tracks like this is indeed necessary.

(although I’m not a reviewer, just to verify what @gbisson said before)

Igor · February 16, 2021, 12:16pm

+1 from me for the creation of these tracks.

roadmr · February 16, 2021, 4:20pm

Thanks for your patience, both tracks for both snaps have been created. Enjoy!

Daniel

gbisson · February 16, 2021, 4:33pm

Thank you all! Right on time, I just finished my core20 upgrade for the kernel, ready to release!