In an attempt to start enforcing warnings with
-Werror in a snap I discovered that headers pulled from system libraries were throwing a number of warnings. In a non-snapcraft environment these warnings are masked because the header files are coming from system include directories. When built in snapcraft the directory that these headers are accessed from is not one of the built in system directories but instead from something like parts/part1/install/include.
What I’m wondering is if it would be reasonable to add these paths to the compiler flags with -isystem instead of -I? I’ve got changes that accomplish this and modify the tests to account for the change but per the contributing file I’m starting a discussion here first.