Snapcraft <step> <part> ignores the <part>

kyrofa · May 7, 2021, 10:38pm

This used to work, and the docs indicate that it still should:

$ snapcraft build --help
Usage: snapcraft build [OPTIONS] <part>...
<snip>

Using current stable (v4.7.1), this only seems to pass snapcraft build to the build instance. Is this a bug, or intended behavior and the docs weren’t updated?

degville · May 11, 2021, 12:02pm

I just gave this a go to see if anything had changed (4.7.1 on LXD), and I think you’re right. For me, snapcraft build <part-name> built all parts (as with snapcraft build). If this is now the correct behaviour (@cjp256 ?), we’ll need to update the help text and the parts docs here (which I’ll do).

cjp256 · May 11, 2021, 2:32pm

Unless I’m missing something, it looks like it’s been that way for a few years at least (if ever in a managed environment).

github.com

snapcore/snapcraft/blob/3.5/snapcraft/internal/build_providers/_base_provider.py#L202


    :returns: True if the prime directory was already mounted.
    """
def expose_prime(self) -> None:
    """Provider steps needed to expose the prime directory to the host.
    """
    os.makedirs(self.project.prime_dir, exist_ok=True)
    if not self._mount_prime_directory():
        self._run(command=["snapcraft", "clean", "--unprime"])
def execute_step(self, step: steps.Step) -> None:
    self._run(command=["snapcraft", step.name])
def clean(self, part_names: Sequence[str]) -> None:
    self._run(command=["snapcraft", "clean"] + list(part_names))
def pack_project(self, *, output: Optional[str] = None) -> None:
    command = ["snapcraft", "snap"]
    if output:
        command.extend(["--output", output])
    self._run(command=command)

There’s some upcoming work to pivot to craft-providers which already effectively addresses this, though may take time before landing in snapcraft. @sergiusens do you have a preference if we fix this now (add & use an optional part_names parameter for execute_step())?