Segmentation Fault running curl

TravisEz13 · March 25, 2019, 5:50pm

We are consistently getting a segmentation fault running curl when trying to build our snap.

This is the line of code that fails:

PowerShell/PowerShell-Snap/blob/13055f686380838e302e85b57395b8a8ca5a567d/preview/snap/snapcraft.yaml#L57


then
  echo "using version file"
  version=$(cat $file)
else
  echo "getting latest version from GitHub"
  version=$(curl -s 'https://raw.githubusercontent.com/PowerShell/PowerShell/master/tools/metadata.json' | jq .PreviewReleaseTag | sed 's/"//g' | sed 's/v//')
  echo "Writing version to file"
  echo $version > $file
fi
echo "getting powershell $version"
curl -L -o powershell.tar.gz https://github.com/PowerShell/PowerShell/releases/download/v$version/powershell-$version-linux-x64.tar.gz
echo "getting Third Party Notice Header"
curl -L -o thirdPartyNoticeHeader.txt https://raw.githubusercontent.com/PowerShell/PowerShell-Snap/master/assets/thirdPartyNoticeHeader.txt
mkdir -p $SNAPCRAFT_PART_INSTALL/opt/powershell
tar zxf powershell.tar.gz -C $SNAPCRAFT_PART_INSTALL/opt/powershell
chmod +x $SNAPCRAFT_PART_INSTALL/opt/powershell/pwsh
thirdPartyNoticeFile="$SNAPCRAFT_PART_INSTALL/thirdPartyNotices.txt"
echo "building third party notices file - $thirdPartyNoticeFile"
cat thirdPartyNoticeHeader.txt > $thirdPartyNoticeFile
find $SNAPCRAFT_PART_INSTALL -type f -name 'copyright' -print | while read filename; do 
  libname=$(dirname $filename | sed 's,^\(.*/\)\?\([^/]*\),\2,')

cc:
@Wimpress
@popey

TravisEz13 · March 25, 2019, 6:01pm

Public CI logs can be seen here: https://powershell.visualstudio.com/PowerShell-Snap/_build/results?buildId=18173&view=logs&jobId=d97e38d3-1e42-5cb1-7166-7d1200a78978&taskId=fedee421-248a-5f74-a3a0-e2827dac54c9&lineStart=1014&lineEnd=1015&colStart=1&colEnd=1

sergiusens · March 25, 2019, 10:59pm

Hi, sorry for the inconvenience.
Do you mind confirming if using snapcore/snapcraft:candidate fixes the issue? This is probably related to PSA: classic confinement and core snapcraft issue

TravisEz13 · March 25, 2019, 11:00pm

I’m not sure I can say I figured it out, but I fixed it.

The PR to fix the issue is here:

Two major changes… We started build the docker container ourselves as the one by snapcore doesn’t seem to work.

Second, I declared base and fixed some other warning snapcraft was giving

TravisEz13 · March 25, 2019, 11:01pm

I tried edge and it did not fix the issue.

sergiusens · March 26, 2019, 11:44am

Use of base: core there is strange, I guess the test is done by just unsquashing per https://powershell.visualstudio.com/PowerShell-Snap/_build/results?buildId=18201 ?

Is there a way to retrieve what was built? I see https://powershell.visualstudio.com/PowerShell-Snap/_build/results?buildId=18204 but it does not tell me much about where things are published.

Additionally, anything related to core18 should not be needed, https://github.com/PowerShell/PowerShell-Snap/pull/24/files#diff-31853519a58aad35c16cfefb2944dc1bR20

Last, if I propose a PR, as an external contributor, does the CI test run and would I be able to retrieve the built snaps?

TravisEz13 · March 26, 2019, 11:40pm

Yes, the agents are containers so we only unsquash to test.

Making the artifacts available was not a feature when I built the CI system. I have a PR to make it actually work. https://github.com/PowerShell/PowerShell-Snap/pull/25 .

The changes related to core18 are commented out.

If you base your changes on PR#25 above, or if it is merged, you should be able to retrieve the built artifacts.