Review sprint #6

It’s that time again!

We have quite a few pending PRs open ranging from major features all the way to trivial tweaks. To ensure these get addressed timely, we’ll have a more focused effort over the next few days to work through them. If you are an author or a reviewer, let’s please collaborate towards that.

Below we have the PRs which were open when the sprint started today, and perhaps a few important ones that were opened later and then integrated into the sprint. The notations used are described after the list.

For any required updates unrelated to status changes, please comment below. Status changes will be updated regularly and automatically.


:white_check_mark::white_check_mark: #4767: interfaces: disconnect hooks {w:pnmz} :white_check_mark::white_check_mark: #4951: interfaces: add screencast-legacy for video and audio recording {j:nmz} :exclamation::exclamation: #5170: interfaces/builtin: add adb interface {z:njb+} :white_check_mark::white_check_mark: #5187: overlord: introduce snapshotstate. {c:pnwm} :white_check_mark::white_check_mark: #5234: snap: add snap list --format=... option {m:bnzwcp} :jack_o_lantern: :white_check_mark::exclamation: #5271: cmd/snap: attempt to start the document portal if running with a session bus {+:zjnb+} :skull: :white_check_mark::white_check_mark: #5307: cmd,interfaces,tests: add /mnt to removable-media interface {z:nmj} :negative_squared_cross_mark::negative_squared_cross_mark: #5318: interfaces/builtin: add new cuda-support interface {+:b+} :white_check_mark::white_check_mark: #5340: interfaces: add cifs-mount interface {+:njz+} (2.36) :white_check_mark::grey_question: #5346: cmd/snap: gnome-software install via snap:// handler {+:nz+} :jack_o_lantern: :white_check_mark::exclamation: #5395: interfaces: generalize writable mimic profile {z:nj} :negative_squared_cross_mark::negative_squared_cross_mark: #5413: tests: purge packages installed by accounts, calendar, and contacts interface tests {+:mzsn} :exclamation::grey_question: #5451: interfaces: honor static attributes when reloading conns {w:znp} :jack_o_lantern: :white_check_mark::exclamation: #5469: interfaces/apparmor: (un)load profiles in one apparmor_parser call {+:zjnbm+} :negative_squared_cross_mark::negative_squared_cross_mark: #5475: WIP: remove unneeded calls to daemon-reload {+:n} :negative_squared_cross_mark::negative_squared_cross_mark: #5495: interfaces/builtin: initial version of the anbox-support interface {+:j+} :exclamation::grey_question: #5497: overlord/patch: patch for static plug/slot attributes {w:np} :white_check_mark::white_check_mark: #5514: daemon, overlord/state: warnings pipeline {c:pn} :jack_o_lantern: :white_check_mark::white_check_mark: #5530: tests: use file based markers in snap-service-stop-mode {m:cz} :white_check_mark::white_check_mark: #5561: overlord/snapstate: parallel snap install {b:pcw} :white_check_mark::exclamation: #5583: cmd/snapd,daemon,overlord: without snaps, stop and wait for socket {m:bcnp} (2.36) :jack_o_lantern: :white_check_mark::negative_squared_cross_mark: #5593: tests: new test for hostname-control interface {s:mbn} :no_entry::exclamation: #5596: [WIP] Parallel installs integration {b:n} :white_check_mark::white_check_mark: #5606: many: add refresh.rate-limit core option {m:nzcbpw} :white_check_mark::white_check_mark: #5614: interfaces: parallel instances support, extend unit tests {b:mw} :white_check_mark::white_check_mark: #5615: interfaces: add new “sysfs-name” to i2c interfaces code {m:bcj} :white_check_mark::white_check_mark: #5618: overlord: instantiate UDevMonitor {w:znmpb} :white_check_mark::negative_squared_cross_mark: #5621: release: detect when apparmor is available but not usable {m:jz+} :exclamation::exclamation: #5623: advise-snap: add --dump-db which dumps the command database {+:cnm+} :jack_o_lantern: :white_check_mark::white_check_mark: #5624: tests: get the linux-image-extra available for the current kernel {s:mb} :white_check_mark::exclamation: #5632: overlord: integrate device enumeration with udev monitor {w:zbn} :jack_o_lantern: :white_check_mark::white_check_mark: #5636: snap: fix advice json {m:zb} (2.35) :negative_squared_cross_mark::negative_squared_cross_mark: #5638: interfaces: basic spread test for udev monitor {w:nz} :white_check_mark::white_check_mark: #5640: tests: skip unsupported architectures for fedora-base-smoke test {s:bz} :white_check_mark::exclamation: #5644: interfaces: add audio-playback/audio-record and make pulseaudio manually connect {j:zn} :white_check_mark::white_check_mark: #5651: cmd/libsnap: unify detection of core/classic with go {z:bw} :negative_squared_cross_mark::negative_squared_cross_mark: #5654: cmd/snap-confine: establish snap directory mappings for parallel instances {b:z} :white_check_mark::white_check_mark: #5655: snap,snap-exec: support command-chain for hooks {+:bn+} :negative_squared_cross_mark::negative_squared_cross_mark: #5659: tests: remove manual from openvswitch test {s:} :white_check_mark::white_check_mark: #5660: wayland: add extra sockets that are used by older toolkits (e.g. gtk3) {+:jmz+} :white_check_mark::white_check_mark: #5661: tests: normalize tests {s:cmbz} :white_check_mark::white_check_mark: #5662: tests: avoid using the journalctl cursor when it has not been created yet {s:cmz} :white_check_mark::white_check_mark: #5664: interfaces: workaround for activated services and newer DBus {j:mbzc} :white_check_mark::white_check_mark: #5666: tests: fix autopkgtest failures in cosmic {m:zsw} (2.35) :white_check_mark::white_check_mark: #5667: store: backward compatible instance-key handling for non-instance snaps {b:cpm} (2.35) :white_check_mark::white_check_mark: #5683: overlord/patch: support for sublevel patches {w:npc} :white_check_mark::negative_squared_cross_mark: #5691: spdx: allow Other-Open-Source {m:bzn} (2.35) :white_check_mark::white_check_mark: #5692: snap-confine: map /var/lib/extrausers into snaps mount-namespace {m:zn} (2.35) :exclamation::grey_question: #5696: interfaces/opengl: add additional accesses for cuda {+:jbzn+} :jack_o_lantern: :white_check_mark::white_check_mark: #5699: overlord,store: support proxy settings internally too {m:nbz} :white_check_mark::white_check_mark: #5703: firstboot: sort by type when installing the firstboot snaps {m:np} :white_check_mark::white_check_mark: #5704: snap: add new type “TypeSnapd” and attach to the snapd snap {m:zbnp} :white_check_mark::white_check_mark: #5707: image: detect and error if bases are missing {m:zn} :white_check_mark::negative_squared_cross_mark: #5709: configcore,snapstate: add new core.experimental.snapd-snap option {m:zb} :white_check_mark::white_check_mark: #5710: cmd: support re-exec into the “snapd” snap {m:zb} :white_check_mark::white_check_mark: #5712: overlord: make InstallMany work like UpdateMany, issuing a single request to get candidates {p:mn} :exclamation::grey_question: #5713: many: mount namespace mapping for parallel installs of snaps {b:jnz} :white_check_mark::grey_question: #5714: tests: new test for cifs-mount interface {s:nb} :jack_o_lantern: :exclamation::grey_question: #5717: snapd: go into degraded mode when the selftest fails {m:nzb} :white_check_mark::white_check_mark: #5718: overlord/ifacestate: remove “old-conn” from connect/undo connect handlers {w:np} :white_check_mark::white_check_mark: #5719: strutil: add new ParseByteSize {m:zbwn} :white_check_mark::white_check_mark: #5720: interfaces/apparmor: do not downgrade confinement on arch with linux-hardened 4.17.4+ {b:zmj} :white_check_mark::white_check_mark: #5722: tests: test for the hostname interface {s:nbcm} :white_check_mark::white_check_mark: #5724: tests: new test for the cpu-control interface {s:mbn} :jack_o_lantern: :white_check_mark::negative_squared_cross_mark: #5726: release, interfaces: make snapd degrade gracefully when AppArmor userspace tooling is unavailable {b:zn}


65 total → ( 0 waiting → 16 reviewing → 4 reviewed → 33 merged ) → 45 closed

Status of each PR:

  • :grey_question: Waiting for review
  • :exclamation: Open review
  • :white_check_mark: Reviewed and approved
  • :white_check_mark: Merged
  • :negative_squared_cross_mark: Closed without merging
  • :no_entry: Blocked
  • :scream: Critical
  • :skull: Decaying
  • :jack_o_lantern: Broken spread tests (click to see)
  • (2.NN) Targets given milestone
  • {.:…} Reviews from regulars (see below)

Regular reviewers

As an aid during the review process, developers participating in reviews regularly are marked with:

  • {1:2345}

Where the regular reviewer:

  1. Submitted the PR
  2. Approved the PR
  3. Was asked to review the PR
  4. Requested changes in PR
  5. Commented on the PR

The following regular reviewers are currently being tracked:

Char Reviewer
b @mborzecki
c @chipaca
j @jdstrand
m @mvo
n @niemeyer
p @pedronis
s @cachio
w @pstolowski
z @zyga-snapd
+ Exceptional

Note that those are the regular reviewers. We have many more contributors than this.