Review sprint #5

It’s that time again!

We have quite a few pending PRs open ranging from major features all the way to trivial tweaks. To ensure these get addressed timely, we’ll have a more focused effort over the next few days to work through them. If you are an author or a reviewer, let’s please collaborate towards that.

Below we have the PRs which were open when the sprint started today, and perhaps a few important ones that were opened later and then integrated into the sprint. The notations used are described after the list.

For any required updates unrelated to status changes, please comment below. Status changes will be updated regularly and automatically.


:white_check_mark::white_check_mark: #4369: interfaces/bulitin: add write permission to optical-drive {+:zjn+} :white_check_mark::negative_squared_cross_mark: #4387: interfaces/gpg-keys: force use of ‘–no-random-seed-file’ via explicit deny {j:znbm} :white_check_mark::grey_question: #4416: tests: performance measurements for basic snapd commands {s:zbm} :white_check_mark::white_check_mark: #4497: many: make rebooting of core on refresh immediate, refactor logic around it {p:nmzwb} (2.33) :white_check_mark::white_check_mark: #4504: snap, wrappers: systemd WatchdogSec support {b:jzmnc} :white_check_mark::white_check_mark: #4510: asserts: use Attrer in policy checks {w:zp} :negative_squared_cross_mark::negative_squared_cross_mark: #4538: interfaces/builtin: Add new steam-support interface {+:jzb+} :white_check_mark::white_check_mark: #4551: ifacestate: do not auto-connect manually disconnected interfaces {w:bcnz} :white_check_mark::white_check_mark: #4562: debian: add a zenity|kdialog suggests {m:bzc} :white_check_mark::negative_squared_cross_mark: #4588: Snapshots! {c:znwb} :white_check_mark::white_check_mark: #4600: configstate: validate known core.* options {m:cbn} :exclamation::grey_question: #4700: interfaces/builtin: add the dvb-video interface {+:zjn} :grey_question::grey_question: #4767: interfaces: disconnect hooks {w:np} :scream::jack_o_lantern: :white_check_mark::white_check_mark: #4790: jsonutil/safejson: introducing safejson.String & safejson.Paragraph {c:pnbz} :white_check_mark::white_check_mark: #4805: daemon: add confinement-options to /v2/system-info {+:wmzcnb} :white_check_mark::white_check_mark: #4844: overlord/snapstate: allow core defaults configuration via ‘system’ key {b:wp} :negative_squared_cross_mark::negative_squared_cross_mark: #4873: many: delay classic registration until first store interaction {p:nb} :white_check_mark::exclamation: #4889: cmd/snap-update-ns: don’t trespass on host filesystem {z:bnp} (2.33) :jack_o_lantern: :exclamation::grey_question: #4917: repo: added repo ConnectionsInfo method (for the new snap connections API) {w:zb} :grey_question::grey_question: #4940: RFC: added UDevMonitor for future hotplug support {w:zbpm} :white_check_mark::exclamation: #4951: interfaces/screenshot: allow access to gnome-shell screenshot/screencast {j:mnz} (2.33) :white_check_mark::white_check_mark: #4968: ifacemgr: remove stale connections on startup {w:bz} :negative_squared_cross_mark::negative_squared_cross_mark: #4970: Add SocketUser and SocketGroup options {+:} :white_check_mark::negative_squared_cross_mark: #4983: osutil/sys, client: add sys.RunAsUidGid, use it for auth.json {c:bz} :white_check_mark::grey_question: #4996: overlord/ifacestate: store and use revision with security profiles set {z:pnbw} :jack_o_lantern: :white_check_mark::white_check_mark: #5016: interfaces/home: add ‘read’ attribute to allow non-owner read to @{HOME} {j:znb} (2.33) :grey_question::grey_question: #5030: packaging/amzn2: initial packaging of 2.32.5 for Amazon Linux 2 {b:z+} :white_check_mark::white_check_mark: #5032: repo: pass and return ConnRef via pointers {w:zb} :negative_squared_cross_mark::negative_squared_cross_mark: #5056: cmd/snap: make confinement mode part of snap version output {b:z} :negative_squared_cross_mark::negative_squared_cross_mark: #5061: tests: ensure interfaces-network-bind daemon is stopped early {m:zs} (2.32) :white_check_mark::white_check_mark: #5066: overlord/snapshotstate/backend: introducing the snapshot backend {c:nb} :white_check_mark::white_check_mark: #5073: set up journal streams in user session application autostart (2.32) {b:mz} :white_check_mark::white_check_mark: #5075: snap/env: fix env duplication logic {+:mwbnz+} (2.32) :white_check_mark::white_check_mark: #5077: overlord/snapstate,overlord/auth,store: coalesce no auth user refresh requests {p:cw} (2.33) :white_check_mark::white_check_mark: #5080: many: support ‘system’ nickname in interfaces {b:ncmw} :white_check_mark::exclamation: #5081: interfaces/apparmor: add chopTree {z:cjb} :white_check_mark::white_check_mark: #5082: cmd/snap-update-ns: use Secure.BindMount to bind mount files {+:bjz} :white_check_mark::white_check_mark: #5090: cmd/snap-update-ns: poke holes when creating source paths for layouts {z:wj} :exclamation::grey_question: #5091: many: hold refresh when on metered connections {b:cpnm+} :white_check_mark::white_check_mark: #5095: snapstate: support getting new bases/default-providers on refresh {m:wb} :white_check_mark::negative_squared_cross_mark: #5102: tests: new utility to save and restore the snap state {s:bzwc} :white_check_mark::white_check_mark: #5107: cmd/snap-update-ns,tests: mimic the mode and ownership of directories {z:wjb} :white_check_mark::white_check_mark: #5115: interfaces: add xdg-document-portal support to desktop interface {+:zbj+} (2.33) :white_check_mark::white_check_mark: #5116: interfaces: move host font update-ns AppArmor rules to desktop interface {+:zbj+} :white_check_mark::negative_squared_cross_mark: #5117: interfaces/apparmor: enable apparmor, even if partial {z:mj} :exclamation::grey_question: #5118: packaging/opensuse: build with apparmor {z:+} :jack_o_lantern: :negative_squared_cross_mark::negative_squared_cross_mark: #5119: dirs: on opensuse store apparmor profiles in /etc/apparmor.d {z:+b} :white_check_mark::white_check_mark: #5120: interfaces: interface hooks for refresh {w:pn} :no_entry::white_check_mark: #5122: snap: add support for snap advise-snap --from-apt {m:zb} :jack_o_lantern: :white_check_mark::white_check_mark: #5124: many: add wait command and seeded target {m:zcnp} (2.32) :white_check_mark::white_check_mark: #5126: cmd/snap-update-ns: add support for ignoring mounts with missing source/target {+:zbj} :white_check_mark::negative_squared_cross_mark: #5132: snap,wrappers: allow “external:{snapd,snapd.seeded}” for snap apps {m:zb} (2.32) :white_check_mark::white_check_mark: #5134: Shrink image generated with snap prepare {+:mcz} :white_check_mark::white_check_mark: #5141: tests: shellchecks, part 1 {b:cz}


54 total → ( 3 waiting → 10 reviewing → 0 reviewed → 29 merged ) → 41 closed

Status of each PR:

  • :grey_question: Waiting for review
  • :exclamation: Open review
  • :white_check_mark: Reviewed and approved
  • :white_check_mark: Merged
  • :negative_squared_cross_mark: Closed without merging
  • :no_entry: Blocked
  • :scream: Critical
  • :skull: Decaying
  • :jack_o_lantern: Broken spread tests (click to see)
  • (2.NN) Targets given milestone
  • {.:…} Reviews from regulars (see below)

Regular reviewers

As an aid during the review process, developers participating in reviews regularly are marked with:

  • {1:2345}

Where the regular reviewer:

  1. Submitted the PR
  2. Approved the PR
  3. Was asked to review the PR
  4. Requested changes in PR
  5. Commented on the PR

The following regular reviewers are currently being tracked:

Char Reviewer
b @mborzecki
c @chipaca
j @jdstrand
m @mvo
n @niemeyer
p @pedronis
s @cachio
w @pstolowski
z @zyga-snapd
+ Exceptional

Note that those are the regular reviewers. We have many more contributors than this.