Review sprint #4

[niemeyer]

It’s that time again!

We have quite a few pending PRs open ranging from major features all the way to trivial tweaks. To ensure these get addressed timely, we’ll have a more focused effort over the next few days to work through them. If you are an author or a reviewer, let’s please collaborate towards that.

Below we have the PRs which were open when the sprint started today, and perhaps a few important ones that were opened later and then integrated into the sprint. The notations used are described after the list.

For any required updates unrelated to status changes, please comment below. Status changes will be updated regularly and automatically.

Reviews

#3734: packaging: add debian-unstable {+:ⁿ_z+} #3916: snap,wrappers: add support for socket activation {+:n_zcj+} #3963: cmd/snap-confine: add support for per-user mounts {+:_z+} #3994: tests: fix revert test when a new core image is pushed {s:z^m_w} #3998: snap-confine, snap-seccomp: utilize new seccomp logging features {+:z^j₊} #4049: debian,vendor: import github.com/snapcore/squashfs and use {m:} #4063: tests: add new kernel refresh/revert test for spread-cron {m:wz} #4068: interfaces/builtin: add support for content “source” section {z:_wm} #4073: snap: add io.snapcraft.Settings to snap userd {m:^j_z} #4078: tests: new test to check interfaces after reboot the system {s:zmw} #4100: add ssh-keys, ssh-public-keys, gpg-keys and gpg-public keys interfaces {j:zⁿ} #4103: snapstate: auto install default-providers for content snaps {m:^zw} (2.30) #4108: repo: ConnectedPlug and ConnectedSlot types {w:pn_z} #4109: cmd/libsnap: fix parsing of empty mountinfo fields {z:b_wj} #4120: repo: use PlugInfo and SlotInfo for permanent plugs/slots {w:zm} #4122: configstate: add support for configure-snapd for snapstate.IgnoreHookError {m:pw} (2.30) #4129: wrappers: do not error on incorrect Exec= lines {m:wz_pc} #4140: interfaces: add an interface for gnome-online-accounts D-Bus service {+:z^j} #4144: interfaces: fix udev tagging for hooks {z:wj^mp} #4149: tests: new tests for network setup control and observe interfaces {s:b_m} #4152: snapd: fix snap cookie bugs {w:pm^z} #4154: overlord/snapstate: support completion for command aliases {c:p_w} #4157: add spread test for connecting all interfaces (excepting gadget slots) {j:bm} #4158: snapctl: don’t error out on start/stop/restart from configure hook during install or refresh {w:pz_m} (2.30) #4159: cmd/snap-confine: add slave PTYs and let devpts newinstance perform mediation {j:_z} #4161: snapstate: add support for refresh.schedule=managed {m:pn_zb} (2.30) #4163: cmd/snap-update-ns: re-factor secureMkdirAll into secureMk{Prefix,Dir} {z:wb_jp} #4166: cmd/snap-update-ns: detect and report read-only filesystems {z:bw} #4169: cmd/snap-update-ns: add secureMkfileAll {z:bj} #4170: cmd/snap-update-ns: add planWritableMimic {z:bj_pm} #4171: tests: adding test to test physical memory observe interface {s:mb_zw} #4173: corecfg: validate refresh.schedule when it is applied {m:zp} #4174: packaging/arch: packaging update {b:z⁺} #4177: state: add change.LaneTasks helper {w:mp_b} #4178: asserts/assertstest: fix use of hardcoded value when the passed or default keys should be used {p:mz} #4179: tests: add a spread test for proxy.store setting together with store assertion {p:mw^s} #4180: interfaces/many: misc policy updates for browser-support, cups-control and network-status {j:mz} #4184: tests: adding new test for uhid interface {s:mz₊} #4185: interfaces/builtin/account_control: use gid owning /etc/shadow to setup seccomp rules {b:zj} #4187: tests: fix xdg-open-compat {m:wb} #4188: osutil: replace cgo bits with non-cgo, vendored os/user {b:^c} #4189: interfaces/builtin/lxd_support: allow discovering of host’s os-release {b:wzm} #4190: cmd/snap-seccomp: do not use group ‘shadow’ in tests {b:wm} #4191: cmd/snap-update-ns: do not assume ‘nogroup’ exists {b:wz} #4192: osutil: add helper for obtaining group ID of given file path {b:wm} #4197: cmd/snap-confine: Support bash as base runtime entry {+:mbj} #4198: release: 2.29.3 {m:z} #4199: cmd/snap-confine: Add support for 32-bit NVIDIA on biarch {+:_b+} #4200: daemon,overlord/snapstate: return snap-not-installed error in more cases. {+:mcz} #4201: tests/lib: handle distro specific grub-editenv naming {b:zm}

Stats

50 total → ( 1 waiting → 7 reviewing → 3 reviewed → 34 merged ) → 39 closed

Status of each PR:

• Waiting for review
• Open review
• Reviewed and approved
• Merged
• Closed without merging
• Blocked
• Critical
• Decaying
• Broken spread tests (click to see)
• (2.NN) Targets given milestone
• {.:…} Reviews from regulars (see below)

Regular reviewers

As an aid during the review process, developers participating in reviews regularly are marked with:

• {1:2³⁴₅}

Where the regular reviewer:

1. Submitted the PR
2. Approved the PR
3. Was asked to review the PR
4. Requested changes in PR
5. Commented on the PR

The following regular reviewers are currently being tracked:

Char	Reviewer
b	@mborzecki
c	@chipaca
j	@jdstrand
m	@mvo
n	@niemeyer
p	@pedronis
s	@cachio
w	@pstolowski
z	@zyga-snapd
+	Exceptional

Note that those are the regular reviewers. We have many more contributors than this.

[niemeyer]

This review sprint round is now finished!

Thanks to everybody who helped getting those bits in (or out :).