Request network-setup-control and system-files, openstack-hypervsior snap

store-requests privileged-interfaces
1
  • name: openstack-hypervisor
  • description: Hypervisor components for OpenStack deployment
  • snapcraft: snap-openstack-hypervisor/snap/snapcraft.yaml at main · canonical/snap-openstack-hypervisor · GitHub
  • upstream-relation: Developer for snap and upstream
  • interfaces:
    • network-setup-control:
      • request-type: installation, auto-connection
      • reasoning: The snap needs to retrieve and modify the Netplan configuration in order to configure DPDK ports.
    • system-files:
      • request-type: installation, auto-connection
      • reasoning: We’ll need to access /etc/driverctl.d in order to set persistent driver bindings (e.g. vfio-pci)
2

This request has been added to the queue for review by the @reviewers team.

3

Hello @lpetrut!

Based on your reasoning, the request for the network-setup-control interface makes sense, so +1 from my side.

Regarding the system-files request, could you please clarify whether you only need read access to the mentioned file? (#askForInfo)

4

Hi @yomonokio,

We need read/write access to /etc/driverctl.d:

etc-driverctl:
    interface: system-files
    write:
    - /etc/driverctl.d

The snap uses driverctl to define persistent driver bindings, e.g.:

driverctl set-override 0000:1a:00.0 vfio-pci

driverctl then stores this configuration in /etc/driverct.d/, as such requiring write access:

$ ls /etc/driverctl.d/
pci-0000:1a:00.0  pci-0000:1a:00.1
$ cat /etc/driverctl.d/pci-0000\:1a\:00.0 
vfio-pci
5

It looks reasonable and makes sense to me. +1 from me for granting openstack-hypervisor auto-connection to the requested interfaces (#voteFor).

6

That all makes sense to me too. +1 (#voteFor)

7

Voting period has ended. This request is approved with 2 votes for and 0 votes against.

8

@lpetrut - please let me know when you upload a revision of the snap that includes the requested interfaces and I’ll go ahead and make the changes live.

Thanks!

9

@cav rev392 was uploaded to the store, waiting on manual review :slight_smile:

1 Like
10

The request was approved and the publisher vetted. This is now live.

2 Likes