Request for manual review: test-snapd-upower-observe-provider

Hi, I’ve just uploaded a test snap to staging, the automated review failed with:

human review required due to 'deny-connection' constraint for 'on-classic' from base declaration declaration-snap-v2_slots_deny-connection (upower, upower-observe)
human review required due to 'deny-connection' constraint for 'on-classic' from base declaration declaration-snap-v2_slots_deny-connection (upower-observe, upower-observe)

The source code is at https://code.launchpad.net/~snappy-dev/snappy-hub/test-snapd-upower-observe-provider and the snap url is https://dashboard.staging.snapcraft.io/dev/snaps/8356/rev/1/ Could someone with review powers take a look?

Thanks!

Hey Federico!

I’ve tried to understand the review errors in order to resolve the manual review, and I’m not sure exactly what the issue is, I’m somehow confused by the mention of ‘on-classic’ considering your snap defines confinement: strict.

Jamie S is on leave until Monday, I talked with @tyhicks to see if we can unblock this today but so far we haven’t been able to.

How urgent is this? Any chance it could wait until Monday?

1 Like

Of course, not urgent at all, Monday is perfectly fine.

Thanks @natalia!

I went to take a look at this but no longer have access to staging since the move from myapps to snapcraft.io. I’ve pinged @natalia on IRC and when I have access, I can take a look.

@jdstrand were you able to complete the review? (so we can close this topic)

Yes, it is taken care of in staging.

Thanks @jdstrand and @natalia! :slight_smile: