Please auto-connect joystick interface for chocolate-doom-jdstrand


#1

https://snapcraft.io/chocolate-doom-jdstrand is a game that is arguably best enjoyed when using a game controller. Please auto-connect the joystick interface.


#2

I approve having vetted the publisher :smiley:


#3

@reviewers - can two or more of you vote on this request?


#4

+1 from me on the auto-connection, it sounds entirely reasonable for a game and the interface is well-constrained.

  • Daniel

#5

+1 from me too - makes sense to do this for all games which use a joystick


#6

Sorry to be annoying about this, but having a few games in the store I’d appreciate some clarity:

  • is it reasonable to be autoconnecting an interface from a trusted packager of untrusted upstream code?
  • should joystick be autoconnected for all games, even those traditionally played by mouse and keyboard?
  • if the threshold for autoconnection is so low, shouldn’t this be autoconnected by default?

#7

I am :+1: for auto-connecting the joystick interface.

Perhaps @alexmurray or @jdstrand would like to answer @mcphail’s question?


#8

I’d like to clarify that I have no objection to the joystick interface being autoconnected in this case; rather, it has taken 16 days for a review of a trivial permission for a trusted packager. There aren’t enough reviewers to thoroughly audit the code, so why do we persist with this security theatre for trivial interfaces? I know I’ve been banging on about this but it doesn’t look as if the system is truly deliverable. Can we have some more of the lower risk interfaces autoconnected by default? The current review system is creaking and cannot be expected to scale.


#9

3 votes for, 0 against. @alexmurray - can you process this request (I cannot since I am the publisher).


#10

On a personal level, I don’t particularly mind how long it took; I certainly didn’t expect any special treatment.

As for scaling: this has been identified as an issue and various teams are working to improve the situation.

As for joystick being trivial: this has been discussed elsewhere and while I agree this is arguably on the edge of being auto-connectable, connecting the interface does expand the kernel surface for something that most snaps do not need, so I think it is still correct to not auto-connect it by default. Games should have it connected, so the process is meant to be lightweight enough to get the approval, and the improvements on resourcing should help with that.


#11

@jdstrand - done - this is now live.