Personal files interface for lutris

store-requests
1

Hey @review-team , as a published for lutris snap i would like to request personal-files interface for lutris , need for the plug ;

  1. To import the user’s configuration from non-snapped Lutris installs.

Please see the following to understand it more ;

  1. https://github.com/CapeCrusader321/Lutris-snap/pull/17
  2. https://github.com/CapeCrusader321/Lutris-snap/issues/10

@lengau can explain more

2

Hi, as the publisher of the snap you could try and provide the information directly in your request here, rather than asking the reviewers to go looking.

As such, in the future, can you please include the personal-files declaration from your snap to show what is being requested access to, with what permission, and what you have named this plug?

I can see from the PR it uses the following:

  lutris-user-config:
    interface: personal-files
    read:
      - $HOME/.config/lutris
      - $HOME/.local/share/lutris

In general we try and name these plugs like dot-config-lutris or dot-local-share-lutris but since in this case you are including both paths in the same plug definition, I think the name you have chosen seems reasonable, as does this use case.

The other option would be to declare write permission for this and then share this configuration between the lutris snap and a non-snapped lutris, however in that case you would have to try and make sure one does not break the other.

In the meantime, +1 from me for use of and auto-connect of this personal-files instance for lutris.

3

Sorry for the wrong format of the request, i will consider all your suggestions recommended when making these types of requests in the future, Thanks.

4

+1 from me for lutris to have read access to $HOME/.config/lutris and $HOME/.local/share/lutris. The snap is not the exclusive owner of these directories but it does seem clear that the application should have at least read-only access to them with auto-connection.

5

hey @SamAlex,

Are you planning to perform the changes required by @alexmurray? I don’t see them yet in https://github.com/CapeCrusader321/Lutris-snap/pull/17/files.

Also, does lutris require read or write access to them?

Thanks!

6

Hey there, the project has been shifted to launchpad from github --> https://launchpad.net/lutris-snap , i have not yet merged the changes needed for personal-files-interface into the main branch since it will block further revisions, snapcraft yaml of lutris with changes for personal-files-interface is stored currently at zenity branch --> https://git.launchpad.net/lutris-snap/tree/snapcraft.yaml?h=zenity and https://git.launchpad.net/lutris-snap/tree/?h=zenity Regarding the changes, i believe alex had agreed that naming convention for the personal-files-interface that is set was correct for our use case plus lutris only needs read access and not write access, thanks for checking out

2 Likes
7

Hi @SamAlex, thanks for the update. Feel free to bump this thread when you do publish lutris with the requested interfaces, it will help us link the failing build in the store (currently non-existent) to this forum topic and get it passing asap.

8

Hi @dclane, it’s done, the revision id is 98. Kindly allow it.

Soumyadeep Ghosh(Collaborator for Lutris)

9

Thank you, I see the changes now. +2 votes for and 0 votes against: Granting personal-files read-only auto-connect for $HOME/.config/lutris and $HOME/.local/share/lutris. This is now live.

1 Like