Personal-files for gitui

store-requests privileged-interfaces
1

To make the review of your request easier, please use the following template to provide all the required details and also include any other information that may be relevant.

  • name: gitui
  • description: terminal-ui for git
  • snapcraft: gitui-snap/snap/snapcraft.yaml at main · sed-i/gitui-snap · GitHub
  • upstream: https://github.com/extrawurst/gitui
  • upstream-relation: none, just enthusiast
  • interfaces:
    • <personal-files>:
      • request-type: installation, and auto-connection
      • reasoning:
        • For gitui to be able to push/pull, it may need read access to ~/.gitconfig to make use of the settings stored there, e.g. [credential], [gpg], [user].
        • For gitui to save its own config files (theme, etc.), it needs read access to ~/.config/gitui/*,
2

gitui to have access to the personal files ~/.gitconfig as it is required for the snaps core functionality. Also since gitui is the clear owner of the file ~/.config/gitui/*, so +1 on granting autoconnection of personal-files interface.

thanks

3

Hey @alexmurray

May I have your approval for this one?

4

Whilst this request looks reasonable, the convention for personal-files is to name the interface after what is being accessed - in this case I think it would be best to split this into two separate personal-files instances:

plugs:
  dot-config-gitui:
    interface: personal-files
    read:
      - $HOME/.config/gitui
  dot-gitconfig:
    interface: personal-files
    read:
      - $HOME/.gitconfig

In which case, +1 for auto-connect of both of these two proposed personal-files instances from me - can you please update your snap to match this?

5

Thanks @alexmurray, and done! Would you be able to re-review please?

6

+2 votes for, 0 votes against, granting auto-connect of personal-files for gitui - this is now live.

1 Like