Migrate from using both build and install to override-build

NeoTheThird · June 5, 2018, 10:52am

I’m using both the build and install keywords:

ubports/ubports-installer/blob/ca24adcdc80b2fab25fc169b035a2aa4e5b10445/snap/snapcraft.yaml#L38


    - libappindicator1
    - libxtst6
    - libnss3
    - libxss1
    - fontconfig-config
    - gconf2
    - libasound2
    - pulseaudio
  after:
    - desktop-glib-only
  build: ./build.js -lb
  install: |
    mkdir $SNAPCRAFT_PART_INSTALL/app
    mv dist/linux-unpacked/* $SNAPCRAFT_PART_INSTALL/app
    mv bin/* $SNAPCRAFT_PART_INSTALL/bin
  prime:
    - -node_modules
    - -lib/node_modules
android-tools:
  source: https://github.com/ubports/android-tools.git
  plugin: make

Since they’re deprecated now, my snap doesn’t build any more. From the deprecation notices (dn8, dn9) i understood this was the correct way to do it:

github.com

ubports/ubports-installer/blob/master/snap/snapcraft.yaml#L38


      - adb-support
      - raw-usb
      - desktop
      - desktop-legacy
      - wayland
    environment:
      "FONTCONFIG_PATH": "$SNAP/etc/fonts"
      "FONTCONFIG_FILE": "$SNAP/etc/fonts/fonts.conf"
      "XDG_DATA_HOME": "$SNAP/usr/share"
      "LD_LIBRARY_PATH": "$SNAP_LIBRARY_PATH:$SNAP/usr/lib/x86_64-linux-gnu/"
parts:
  ubports-installer:
    plugin: dump
    source: .
    build-packages:
      - npm
      - nodejs
      - libgconf-2-4
    stage-packages:
      - libusb-1.0-0

It seems this is not entirely correct, though. I’m not exactly sure why, but snapcraft seems to try to still try to run some default build. Here’s where it’s failing:

Building desktop-gtk2 
+ snapcraftctl build
make FLAVOR=gtk2 -j4
gcc -Wall -O2 -o bindtextdomain.so -fPIC -shared ./../src/bindtextdomain.c -ldl
make FLAVOR=gtk2 install DESTDIR=/home/neothethird/Code/ubports-installer/dist/__snap-x64/parts/desktop-gtk2/install
install -D -m755 desktop-launch /home/neothethird/Code/ubports-installer/dist/__snap-x64/parts/desktop-gtk2/install/bin/desktop-launch
install -D -m644 flavor-select /home/neothethird/Code/ubports-installer/dist/__snap-x64/parts/desktop-gtk2/install/
install -D -m644 bindtextdomain.so /home/neothethird/Code/ubports-installer/dist/__snap-x64/parts/desktop-gtk2/install/
+ export XDG_DATA_DIRS=/home/neothethird/Code/ubports-installer/dist/__snap-x64/parts/desktop-gtk2/install/usr/share
+ update-mime-database /home/neothethird/Code/ubports-installer/dist/__snap-x64/parts/desktop-gtk2/install/usr/share/mime
+ [ -f /home/neothethird/Code/ubports-installer/dist/__snap-x64/parts/desktop-gtk2/install/usr/share/icons/Adwaita//index.theme ]
+ 
+ gtk-update-icon-cache-3.0 -q /home/neothethird/Code/ubports-installer/dist/__snap-x64/parts/desktop-gtk2/install/usr/share/icons/Adwaita/
+ which gtk-update-icon-cache-3.0
/bin/sh: 36: gtk-update-icon-cache-3.0: not found
Failed to run 'override-build': Exit code was 127.
  ⨯ exit status 2

Adding gtk-update-icon-cache to the build-packages doesn’t help. Sorry for this specific support question, but i’m pretty sure this was introduced by the deprecation of these keywords…

lucyllewy · June 5, 2018, 11:14am

Your yaml is showing that you wanted desktop-glib-only but your build output shows it building desktop-gtk2. The error appears to be something wrong with the desktop-gtk2 part not finding an executable file it requires for the build.

sergiusens · June 5, 2018, 12:14pm

Deprecation doesn’t means it gets to break; if it really is the case (which I certainly hope not as we have tests still using build and install for such purposes), then please log a bug.