recently the gnome-calculator snap updated to version 3.30 in Ubuntu 18.04 which is great and exactly one reason why snaps are awesome.
One minor issue appeared with this update: the icon used previously the Suru icon for the calculator if Suru icon theme was selected but now it uses the stock adwaita icon:
Would be great if youâd find time to fix this, it was using the correct icon for several months
A second issue (that is not directly related to the update) is, that it uses an outdated version of the Yaru/Communitheme theme. It must be several months old (I see this because it uses some old styling we changed) and it would be great if you could update this, too. Other snaps like system monitor, libre office and logs use this outdated version, too.
On the theme refresh, a new version in the edge channel for gtk-common-themes is automatically published whenever a new Yaru commit is in master. @kenvandine, @jamesh, I think you are the ones with publisher rights to the stable channel, mind publishing it regularly?
We were just talking about what to do about publishing gtk-common-theme. We merged some fixes on Friday but need a way to trigger builds outside of Yaru theme updates.
I wonder what happens in Cosmic when application, cursor and icon theme are all named Yaru (not like 18.04 with the communitheme [old name] snap which uses communitheme/communitheme/suru for application/cursor/icon themes)?
Is there some reference/pointer to the correct name somewhere in the gtk-common-themes snap? Or does it always look for âSuruâ for cursor and icon thems?
itâs âorg.gnome.Calculatorâ now instead of âgnome-calculatorâ, the snap generated .desktop has a complete path to the icon where it seems he had the name only referenced before (is there a special case for when the snap and icon_name are identical?)
Yeah, that was a fix for the app icon on other distros. Iâll get a proper fix soon. I guess just changing it back to gnome-calculator might get the themed icon.
Looking at the revisions of the snap still on my system, rev 199 has:
Icon=gnome-calculator
And rev 222 has:
Icon=${SNAP}/meta/gui/gnome-calculator.png
The first is a symbolic name that could be overridden by the theme, but will likely not be found if the icon theme doesnât override it. The second is a full path that will work everywhere but canât be themed.
To allow reliable theming of snap application icons, weâd want some way for them to install their icon into the hicolor theme (and possibly other themes if they have produced multiple versions) and then that symbolic name in the desktop file. This would also allow the app to provide multiple sizes of their icon rather than having a single version scaled.
A quick sketch of a possible implementation:
snaps can optionally provide a meta/icons subtree that follows the layout of a âbase directoryâ according to the icon theme spec.
when installing or upgrading the snap, snapd will symlink or copy the provided icons into /var/lib/snapd/desktop/icons.
One question weâd need to solve is âwhat symbolic icon names should a snap be allowed to provide?â. If a snap called gnome-calculator is allowed to provide org.gnome.Calculator, whatâs to stop it also replacing the icon for Firefox? But at the same time if we limited the snap to providing names prefixed by the snap name, then icon theme authors would need to override the icon twice: once for the snapped version of the app and once for the regular or flatpak version.
I guess I was using the wrong terminology. I was trying to refer to the difference between abstract names like gnome-calculator or org.gnome.Calculator that can pick different images based on theme and rendered size. This was to contrast it to concrete file names like /path/to/gnome-calculator.png that can only ever refer to one image.
I probably should have just said âicon nameâ.
As for why the change occurred, there is code in Snapcraft to rewrite the icon field of the desktop file. It looks like that should only happen if it already contains an absolute path name though. So itâs not obvious what caused the change.
The gnome-characters snap also uses the adwaita icon. Shall I open another thread for this or could you handle this in this context? Aaaand the gnome-logs application, too @jamesh
The 3.30 versions of gnome-calculator, gnome-characters and gnome-logs have all been released to stable now and now use the themed icon rather than the application icon.
Hmhm this seems to be my current status after refreshing successfully those 4 apps:
gnome-characters & gnome-calculator both updated to 3.29.91 and 3.30 - correct icon everywhere
gnome-logs updated to 3.30 - old icon in shell - new icon in the app:
I try to reinstall one of the apps and see if this solves those issues
Edit: I tried to refresh from --edge but that were only version downgrades to I went back to stable. I guess I only need to wait some days until the update hits
@kenvandine
Found another minor issue with two of new gnome 3.30 snaps:
gnome-calendar and gnome-contacts 3.30 use the wrong âclickâ hand when you can click elements and the wrong âincrease window sizeâ cursor at the edges of the window:
@kenvandine@jamesh
any update on icon and cursor issues?
Would be awesome to have this ready before 18.10
People already complain about the icon mix, this would reduce it yet a little bit.
which is great and exactly one reason why snaps are awesome.
gnome-logs updated to 3.30 - old icon in shell - new icon in the app: 
