Generic wayland icons in snap title bars in KDE

soumyaDghosh · May 27, 2024, 9:34am

In KDE, each app have a icon set to their window. But, because it’s set via QIcon::themedIcon, those only searches for the icon with those names. Now, it’s set by the app itself, it should’ve access to the theme icon as the path where the icon is installed, $SNAP/usr/share/icons/hicolor is in the XDG_DATA_DIRS. Then why do we still get a generic window icon on the titlebars? Is there any way to fix this? This seems to be can be fixed again with implementation of themed icons in snap icons, as seen in many previous threads.

For ref:

https://invent.kde.org/utilities/kweather/-/blob/master/src/main.cpp#L83

soumyaDghosh · May 27, 2024, 3:39pm

Follow up, found an interesting PR. The renaming of desktop file was probably not because it created some issues with snapd, rather Unity8 had some issues with it. I am not sure about the userbase of Unity right now. But, I am definitely sure that it’s far less than (may be mere 10-20%) of all the Gnome, KDE, Cinnamon, Mate, XFCE combined. I really think we should go forward and revert the change, atleast on snapcraft and create an experimental flag in snapd, similar to multi instance installations.

Ref:

https://github.com/canonical/snapcraft/pull/1074/files

github.com

snapcore/snapd/blob/master/wrappers/desktop.go#L268


      
          	for _, df := range desktopFiles {
          		base := filepath.Base(df)
          		fileContent, err := os.ReadFile(df)
          		if err != nil {
          			return nil, err
          		}
          		// FIXME: don't blindly use the snap desktop filename, mangle it
          		// but we can't just use the app name because a desktop file
          		// may call the same app with multiple parameters, e.g.
          		// --create-new, --open-existing etc
          		base = fmt.Sprintf("%s_%s", s.DesktopPrefix(), base)
          		installedDesktopFileName := filepath.Join(dirs.SnapDesktopFilesDir, base)
          		fileContent = sanitizeDesktopFile(s, installedDesktopFileName, fileContent)
          		content[base] = &osutil.MemoryFileState{
          			Content: fileContent,
          			Mode:    0644,
          		}
          	}
          	return content, nil
          }

YamiYukiSenpai · May 30, 2024, 12:52pm

This is the same issue with my Firefox Nightly (parallel install) on Wayland

Hope there’s a solution for this. Its a bit of an eyesore

soumyaDghosh · June 3, 2024, 7:26am

@ogra @alexmurray @kenvandine can anyone kindly comment on this?

alexmurray · June 4, 2024, 4:13am

@soumyaDghosh I think the best course of action here (if you want to try and get this change reverted) would be to send a PR to the snapcraft project so it can be discussed directly with the snapcraft developers.

soumyaDghosh · June 4, 2024, 4:27am

This change is now a lot more hardcoded than before. Because it was at the initial days and a lot of work has been done regarding that. I did look into it for a day, but sure, I’ll try. It’s not only snapcraft but also snapd. Both are huge libraries.