File chooser not focused

LyzardKing · January 20, 2021, 10:30am

Hi.
In the ksnip snap (available upstream at https://github.com/ksnip/ksnip) if we select save as it opens the gtk native file chooser from the gnome extension.
The problem is that it opens in the background, not focused.
What could be the issue?

keshavnrj · January 20, 2021, 12:39pm

I understand what you are saying, The FileDialog needs the correct parent widget.
I was able to reproduce the same issue with a simple qt test program.
The developer of ksnip needs to set the correct parent window to the file dialog. Setting a nullptr will not work and will result the file dialog lose focus.
Pinging : @damir

damir · January 20, 2021, 1:05pm

Thanks for the hint, I’ll give it a try

damir · January 20, 2021, 3:33pm

That doesn’t seem to be the issue, parent was already set for that dialog.
Any other ideas? Maybe using non native dialog?

keshavnrj · January 21, 2021, 5:52am

Parent object must be root window. Using non-native window should not cause this issue (I tested that).

ilya-fedin · January 22, 2021, 7:52am

It’s an incompatibility between Qt and xdg-desktop-portal-gtk, the first sends window ID as a decimal, while the last expects a hexadecimal value:

jamesh · January 22, 2021, 9:41am

Yep. This seems to be the problem code in Qt:

github.com

qt/qtbase/blob/946facb1ae5ed1cf54bb5141bc5ca20ddbb26755/src/plugins/platformthemes/xdgdesktopportal/qxdgdesktopportalfiledialog.cpp#L188


}
void QXdgDesktopPortalFileDialog::openPortal()
{
    Q_D(QXdgDesktopPortalFileDialog);
    QDBusMessage message = QDBusMessage::createMethodCall(QLatin1String("org.freedesktop.portal.Desktop"),
                                                          QLatin1String("/org/freedesktop/portal/desktop"),
                                                          QLatin1String("org.freedesktop.portal.FileChooser"),
                                                          d->saveFile ? QLatin1String("SaveFile") : QLatin1String("OpenFile"));
    QString parentWindowId = QLatin1String("x11:") + QString::number(d->winId);
    QVariantMap options;
    if (!d->acceptLabel.isEmpty())
        options.insert(QLatin1String("accept_label"), d->acceptLabel);
    options.insert(QLatin1String("modal"), d->modal);
    options.insert(QLatin1String("multiple"), d->multipleFiles);
    options.insert(QLatin1String("directory"), d->directoryMode);
    if (d->saveFile) {

The change suggested in that xdg-desktop-portal-gtk PR would break all non-Qt clients, and it’s not clear that the problem can be reliably detected on that side since the decimal representation of an ID can also be the hexadecimal representation of a different ID.

ppd · October 31, 2021, 6:00pm

@jriddell

The upstream patch to fix this very annoying bug is here: https://github.com/qt/qtbase/commit/acaabc9108dfe75530960cf8e3ec4f3602cd82e0.patch

I’m not too acquainted with Debian packaging, but I think adding it in https://invent.kde.org/neon/qt/qtbase/-/tree/Neon/release/debian/patches and rebuilding the framework snap(s) should do the trick.

ppd · November 3, 2021, 9:37am

I filed a bug @ https://bugs.kde.org/show_bug.cgi?id=444873

ppd · November 4, 2021, 9:43am

@jriddell And I tried my hand at including the patch: https://invent.kde.org/neon/qt/qtbase/-/merge_requests/3

Edit:

And the patch has been merged, and the problem is solved in kde-frameworks-5-qt-5-15-3-core20 for revision >= 7. This will hit stable soon, and most kde-neon applications should pick up the fix.