Download size = -1 (snap download)

futuretim · July 7, 2021, 1:39am

snapcore/snapd/blob/1d23bf1e1464feb1f0f6664f89ea6fba81be68de/store/store_download.go#L482


			return &DownloadError{Code: resp.StatusCode, URL: resp.Request.URL}
		}
		if pbar == nil {
			pbar = progress.Null
		}
		dlSize = float64(resp.ContentLength)
		if resp.ContentLength == 0 {
			logger.Noticef("Unexpected Content-Length: 0 for %s", downloadURL)
		} else {
			logger.Debugf("Download size for %s: %d", downloadURL, resp.ContentLength)
		}
		pbar.Start(name, dlSize)
		mw := io.MultiWriter(w, h, pbar, tc)
		var limiter io.Reader
		limiter = resp.Body
		if limit := dlOpts.RateLimit; limit > 0 {
			bucket := ratelimit.NewBucketWithRate(float64(limit), 2*limit)
			limiter = ratelimitReader(resp.Body, bucket)
		}

It seems like this could have better checking and bail out with more reasons why if the content length is -1.

Why doesn’t this code bail when things are as they expect? You can wind up in the situation I’m in where I’m trying to debug sha3_384 mismatches and I think it was a Content-Length not being set issue.

futuretim · July 7, 2021, 1:45am

I guess I was wrong. It appears as though it’s downloading at least something.