Brave release blocked on manual review due to mpris, please approve

store-requests
1

Hi,

I’m an engineer at Brave and I’d like to request manual approval for the latest Brave browser [0] release 1.51.110 (for x64 [1] and arm64 [2]).

We’ve had the slots:mpris entry in our snapcraft.yaml for 2.5 years [3]. Recently a user submitted a PR [4] to add the missing slots:mpris:interface/name entries needed to make the feature work. We adjusted the name [5] and pushed out a new release.

I figured the old slots:mpris entry meant we had all the needed approvals, but apparently that got flagged anyway.

This functionality is present in other browser snaps.

Please approve our latest release, so users can update.

Thanks.

[0] https://snapcraft.io/brave
[1] https://dashboard.snapcraft.io/snaps/brave/revisions/232/
[2] https://dashboard.snapcraft.io/snaps/brave/revisions/233/
[3] https://github.com/brave/brave-browser-snap/blame/stable/snapcraft.yaml#L44
[4] https://github.com/brave/brave-browser-snap/pull/19/files
[5] https://github.com/brave/brave-browser-snap/blame/stable/snapcraft.yaml#L52

1 Like
2

Done :slight_smile: - the brave snap is now passing automated review.

3

Thanks @alexmurray! It looks like the x64 release is unblocked, but not arm64…

4

Ah thanks for letting me know - I have just rerun the automated review on that revision and it looks to have passed as well. With any luck, future revisions should pass automatically now.

5

Thanks!

…