+1 from me for granting read access to ~/.gitconfig and ~/.config/git via personal-files interface and * /etc/gitconfig* via personal-files interface. Even if the snap is not the clear owner of those files, they are clearly needed for the snap operation. Publisher vetting will be required in this case.
Whilst placing git repos on external media may be a bit niche, I’m still giving a +1 for auto-connection to removable-media as it sounds reasonable to me.
ssh-keys interface is quite sensitive as it exposes user’s private keys. I would prefer to stick to manual connection and let the user decide.
home and network interfaces should not require any additional permissions for auto-connection.
I understand that ssh-keys is a sensitive interface, but I would consider being able to push, pull and fetch from remotes to be a fundamental feature of a git tool.
I know that non-authenticated fetching would still work, but I imagine the majority of developers use ssh authentication for remote repos.
Hey @mr_cal, I agree it is a fundamental feature but I would let the user manually connect to it since user should know what snap is accessing in this case.
+1 from me for auto-connecting read access to ~/.gitconfig and ~/.config/git via personal-files interface and /etc/gitconfig via personal-files interface, and +1 on the manual connect on the ssh-keys interface to this snap
@mr_cal Can you please rename the personal-files instance to dot-gitconfig to match the usual precedence around this, and similarly the system-files interface as etc-gitconfig? Thanks