Auto-connect request for logseq

store-requests
1

Logseq requires control over a git repository as a way of syncing the user graphs. When enabled, git commit is periodically executed by logseq and a hook takes care of git push: everything is detailed here: https://hub.logseq.com/integrations/aV9AgETypcPcf8avYcHXQT/logseq-sync-with-git-and-github/krMyU6jSEN8jG2Yjvifu9i

Since Logseq sync is still in beta and it’s also a paid feature, GIT sync is one of the most used way to sync the user graphs.

Similar to what did for the hugo snap (see System-files and personal-files request for hugo) I added three interfaces I’d like to autoconnect:

  • system-gitconfig (read permission over /etc/gitconfig)
  • user-gitconfig (read permission over ~/.gitconfig and ~/.config/gitconfig)
  • ssh-keys since those backup repositories are rarely public

A reference to my latest commit which triggered the manual review for those interfaces: https://github.com/p-gentili/logseq/commit/f60438118421b93cca36f52dec995bd6c304daaf

2

@pgentili, can you please use the interface names etc-gitconfig and gitconfig to be consistent with other snaps?

+1 from me for auto-connect of system-files named etc-gitconfig for read access to /etc/gitconfig and for personal-files named gitconfig for read access to ~/.gitconfig and ~/.config/git/config for logseq as this is a standard feature of this snap.

auto-connect to ssh-keys looks risky, have you explored the option of using OAuth instead of using ssh private key for git push

thanks

3

@0xnishit thanks for the quick answer.

Updated the interface names as requested, see here.

For SSH keys, using OAuth could be a possibility of course but it really depends on the platform and it feels a bit more like a workaround than a real solution. The official guide does not mention it and it’ll be difficult for a community based snap to sponsor it.

4

true, I understand your concern, but I am thinking from a user point of view as well. @reviewers can help if they have a better solution

Also, the git-syncing part is optional, not every user uses it, how about granting the ssh-keys interface to manual-connect and not auto-connect?

5

I’m actually Ok with that. I can add instructions on the listing page.

6

+1 to auto-connect etc-gitconfig and gitconfig.

I am also in favour of leaving ssh-keys manually connected if the user so desires.

7

thanks, +1 from me as well to auto-connect etc-gitconfig and gitconfig interfaces and manually connect to ssh-keys interface

8

+2 votes for auto-connecting etc-gitconfig and gitconfig. Please submit a revision that includes these interface references and we can grant the appropriate auto-connections.

9

Now pending manual review.

10

My apologies, before we grant these we must do publisher vetting as system-files and personal-files are both super-privileged interfaces. @advocacy / @igor can you please perform the required vetting?

11

+1 from me, I verified the publisher.

12

Granting auto connect of etc-gitconfig and gitconfig to logseq. Could you please resubmit it for manual review.