Theme Connector For Snaps classic confinement

[jdstrand]

@jamesh

As for connecting up slots, this will be handled by the greedy connection support as mentioned by @galgalesh. There are a few points to keep in mind though:

1. the greedy connection feature relies on snap declarations provided by the store to indicate that multiple connection is desired. This would need to be provided by gtk-common-themes and all other snaps providing the slot.

@jamesh and/or @kenvandine - whenever you are ready to add the greedy plugs, please add a new topic to the store-requests category.

[pedronis]

@jamesh

I’d prefer you wait until we have the review tools checks in place. We want to make sure all theme snaps eligible to install are “safe”, and we don’t yet have a complete picture of what that means yet. It will probably include:

1. Contains the expected content interface slots
2. Shared content is valid (valid images, valid CSS, etc).
3. The snap does not provide any apps, daemons, or hooks

@jamesh @jdstrand what would trigger the check? simply the presence of “theme” in the snap name? the presence of slots with theme related “content” labels? this will need to be stateful, once a snap is considered a theme it will need to be checked even if it lost the property that made it checked once I think, because themes will be refreshed.

snapd will have to either have a way to trust the store that something that is being installed automatically was vetted or to do the same checks as well

[jamesh]

I suppose we could add paired rules like:

1. snaps whose name begins with gtk-theme- must provide a content interface slot with ID gtk-3-themes.
2. snaps that provide a content interface ID of gtk-3-themes or gtk-2-themes must be named gtk-common-themes or have a name beginning with gtk-theme-.

(and similar for icon and sound themes).

That would ensure the other validation routines apply to the snap and it can’t stop being a theme snap.