- name: apparmor-language-server
- description: Language server for AppArmor profiles
- snapcraft: https://gitlab.com/apparmor/apparmor-language-server/-/blob/main/snap/snapcraft.yaml?ref_type=heads
- upstream: https://gitlab.com/apparmor/apparmor-language-server
- upstream-relation: I am the upstream developer and maintainer
- interfaces:
- hostfs-etc-apparmor (system-files):
- request-type: auto-connection
- reasoning: this plug provides
readaccess to/var/lib/snapd/hostfs/etc/apparmor.dand/var/lib/snapd/hostfs/etc/apparmoron the host - this is needed so that the snap can read#include <abstractions/…>etc in AppArmor profiles from the host as well as the parser’s configuration file.
- hostfs-etc-apparmor (system-files):
+1 from me, that seems like a perfectly reasonable requirement for an AppArmor LSP.
Apologies, I have just realised that within the snap mount namespace /etc/apparmor.d comes from the base snap, not from the host - so instead I have changed this request to read these via /var/lib/snapd/hostfs/etc/apparmor.d - also we need to access the /etc/apparmor directory from the host as well as this contains the parser configuration file too. To avoid multiple plugs I have put both these paths under the same plug.
Ping @reviewers, any chance someone can take a look at this? Thanks
Hey @alexmurray 
Given the snap’s functionality, the request makes sense so that’s a +1 (#voteFor) from my side.
+1 from me as well, makes sense to need this.
@jslarraz any chance you could process this request? It has the required votes now from what I can see. Thanks 
Hey folks!
This request sounds reasonable to me. +2 for, 0 against granting apparmor-language-server read access to /var/lib/snapd/hostfs/etc/apparmor.d and /var/lib/snapd/hostfs/etc/apparmor via system-files interface. This is now live.
Really looking forward to try this language server, I think it will be really helpful
Thanks!
Thanks @jslarraz I’m keen for any feedback you may have 