System-files request for apparmor-language-server

[alexmurray]

• name: apparmor-language-server
• description: Language server for AppArmor profiles
• snapcraft: https://gitlab.com/apparmor/apparmor-language-server/-/blob/main/snap/snapcraft.yaml?ref_type=heads
• upstream: https://gitlab.com/apparmor/apparmor-language-server
• upstream-relation: I am the upstream developer and maintainer
• interfaces:
  • hostfs-etc-apparmor (system-files):
    • request-type: auto-connection
    • reasoning: this plug provides read access to /var/lib/snapd/hostfs/etc/apparmor.d and /var/lib/snapd/hostfs/etc/apparmor on the host - this is needed so that the snap can read #include <abstractions/…> etc in AppArmor profiles from the host as well as the parser’s configuration file.

[Wimpress]

+1 from me, that seems like a perfectly reasonable requirement for an AppArmor LSP.

[alexmurray]

Apologies, I have just realised that within the snap mount namespace /etc/apparmor.d comes from the base snap, not from the host - so instead I have changed this request to read these via /var/lib/snapd/hostfs/etc/apparmor.d - also we need to access the /etc/apparmor directory from the host as well as this contains the parser configuration file too. To avoid multiple plugs I have put both these paths under the same plug.