As an update, there’s only one piece missing in this story which is the integration of the store-provided common-id with snapd so that it will expose that through its API. We have this work scheduled for the current cycle and hope to finish it soon.
2 Likes
FYI I’ve started looking at the snapd side of things.
1 Like
PR to snapd is open for reviews right here:
https://github.com/snapcore/snapd/pull/5199
afaict it seems snapcraft doesn’t prevent multiple apps in the same snapcraft.yaml to have/repeat the same common-id, is that intended?
@pedronis No, not intended. It’s okay for multiple applications to have the same common-id, given that the snaps might be alternatives to the same piece of software, but it doesn’t make much sense for these to be in the same snap.
Is this something we should do in snap pack or in snapcraft itself?
@pedronis do you know if the review tools already check for this condition?
as we were just discussing with @niemeyer it’s probably not expected but doesn’t have a big impact on how snapd/the store use common-id, but I see code in snapcraft that seems to cross-reference common-id and desktop files which I don’t fully understand and don’t know how is affected by repeated common-ids
@sergiusens @pedronis I suggest rejecting it for now. It’s easier to allow it later than to reject it later.
review-tools should also check for this then, cc @jdstrand
Shall I check for duplicate common-ids in snap pack --check-skeleton then?
Yeah, certainly sounds reasonable.
The review-tools don’t do this, but certainly can. I’ll adjust.
1 Like
This is committed to master and will be in production hopefully next week.
1 Like
The snapd piece of the puzzle has just landed.
In 2.33 (out 11th June) or in master (presumably 2.34)?
Oh, jdstrand’s post implies master (2.34) my bad?
I have deployed that new version of the click reviewers tools to the production store; snaps with multiple repeated common-ids will now be flagged.
Support landed in snapd-glib 1.41.