Manual review for olivia-test


#1

i am testing mpris integration with my current snap build, i found i need expose a dbus interface so i modified snapcraft.yaml file, and also added mpris interface to it. just adding mpris interface didn’t worked so i did dbus too, which revoked this manual review thing.

https://dashboard.snapcraft.io/snaps/olivia-test/revisions/169/review/


#2

Please note that the mpris interace also allows specifying the ‘name’ attribute. Looking at your manual review request, you have an unusual dbus name of simply ‘olivia’ which might indicate why mpris didn’t work since your snap’s name is ‘olivia-test’. Please try:

slots:
  mpris:
    name: olivia
apps:
  olivia:
    ...
    slots:
    - mpris

This will allow binding to org.mpris.MediaPlayer2.olivia.

Is there any reason why you chose ‘olivia-test’ as the snap name instead of ‘olivia’? As it stands, to pass automated review you will need a snap declaration for use of ‘olivia’ with the mpris interface since your snap is named ‘olivia-test’, but if it was named ‘olivia’, you would not.


#3

can i change the name of my snap or migrate the content to “olivia” ? :thinking:
cause there are lots of articles which tells how to install olivia as “snap install olivia-test” .
if this is not possible i will publish all this work to olivia which will take some work.


#4

do i need to add interface: mpris
under mpris: in slot definition ?


#5

@jdstrand i setup a auto build with build.snapcraft.io with name olivia and deleted olivia-test , now the build is taking forever, its been an hour already and am not seeing anything released in olivia namespace. kindly check the issue plz.


#6

The build service is a free one with no guarantee of service. Please be patient when building on it. It looked like your snap finished building a few moments ago.

https://launchpad.net/~build.snapcraft.io/+snap/1ad2f4d46093b6fdff0f98279b385b15


#7

yes it just happened, i thought its a bug or something like that, maybe caused due to messed up names switching etc… i guess maintenance break is also goin on.


#8

If you renamed your snap, all you need is:

name: olivia
apps:
  olivia:
    slots:
    - mpris

If still using olivia-test, then you need:

name: olivia-test
slots:
  mpris:
    name: olivia
apps:
  olivia:
    ...
    slots:
    - mpris

#9

i changed the name of snap its working thanks @jdstrand :heart_eyes: