Call for testing of the docker snap

snap
35

Hi again,

Apologies for not getting back to this sooner, but a couple of things:

  • the AppArmor profile you modified is generated by snapd so it should not really ever be modified manually except during development perhaps
  • the correct place to get modifications made to the AppArmor profile generated by snapd is not in the docker snap itself but rather in the docker-support interface which is in the snapd project: https://github.com/snapcore/snapd/blob/master/interfaces/builtin/docker_support.go
  • after modifications made to the snapd interface have been merged to master, they will not usually be released right away to stable (though they will likely land in edge within a day or so) and instead will follow the snapd release cycle, but if there’s something critically broken or missing then we can try to get it released to the stable channel sooner
  • the necessary bits in docker-support to accommodate docker 18.09.03-ce are now in the stable channel, so we should push up an update soon

Additionally, you can submit MPs (merge proposals - launchpad parlance for pull requests) against the docker snap on launchpad by:

  1. Create a launchpad/ubuntu SSO account
  2. Clone the repository from git+ssh://$YOUR_LP_USER@git.launchpad.net/~docker/+git/snap
  3. Create a local git branch with the changes you want to see
  4. Push your branch to the launchpad with the remote url $YOUR_LP_USER@git.launchpad.net:~$YOUR_LP_USER/+git/docker-snap - note that you don’t need to do anything to create the repo in LP beforehand as launchpad will create the repo for you when you push it.
  5. Go to code.launchpad.net/~$YOUR_LP_USER/+git/docker-snap/ and click on the branch you want to propose a merge for
  6. Click “Propose for merging”
  7. Under “Target repository” choose Other: and fill in lp:~docker/+git/snap and the target branch as master (the snap builds from the master branch)
  8. Fill in the description of the change and click propose merge
  9. We (probably me but possibly someone else in the future) will review the MP and do our best to get it integrated

Lastly, as you may have noticed snapd 2.38 has landed in stable now so we should be pushing out a new update to docker version 18.09.03-ce on the beta channel soon

2 Likes