- name: leaf
- description: Leaf is a terminal-based Markdown previewer with syntax highlighting, LaTeX rendering, Mermaid diagrams, theme support, and interactive navigation.
- snapcraft: leaf-snap/snap/snapcraft.yaml at main · mr-cal/leaf-snap · GitHub
- upstream: GitHub - RivoLink/leaf: Terminal Markdown previewer — GUI-like experience. · GitHub
- upstream-relation: n/a - unofficial snap package
- interfaces:
- personal-files:
- request-type: auto-connection
- reasoning: leaf needs to read and write to its config directory,
~/.config/leaf
- removable-media:
- request-type: auto-connection
- reasoning: to preview markdown files on removable media, such as a flash drive of personal markdown notes
- personal-files:
This request has been added to the queue for review by the @reviewers team.
+1 from my side on autoconnecting personal-files interface on ~/.config/leafkm dir and removable-media interface, as these are very much aligned with the requirements of the working of this snap, given that publisher vetting is successful.
Also, I request if @mr_cal can try to make this snap as part of the official repo only
thanks
Hi @mr_cal,
+1 from my side to grant auto-connection to personal-files interface after publisher vetting.
For removable-media, as per Process for aliases, auto-connections and tracks, I do not think this application quite fits in the exception category. So, I would suggest to use manual connection for this interface.
Let us know your thoughts on this.
I think the following exception applies, since Leaf is a media viewer for markdown files:
media (eg, sound, photo, video) players/viewers (rationale: the software is very often used to import/preview/playback files on external devices)
Hi @mr_cal,
I agree that it can be used to access markdown from the removable-media but it is not the core functionality of the app.
(rationale: the software is very often used to import/preview/playback files on external devices)
From the exception, I do not think the software is used very often to import files on external devices and I still think removable-media should be connected manually.
Kindly let me know if you still think otherwise.
Hi @shishirsub10,
From the exception, I do not think the software is used very often to import files on external devices and I still think
removable-mediashould be connected manually.
I agree that it’s not tool for importing, but I’m focusing on “preview”, not “import” in the exception:
media (eg, sound, photo, video) players/viewers (rationale: the software is very often used to import/preview/playback files on external devices)
Leaf is a media viewer that can be used to preview files on external devices, so I think it fits this exception.
I’m inclined to agree with the security review here. I think the snap will still be useful in a large number of cases without needing the auto-connect on removable-media. For now I think just approving the personal-files request is the right path.
One option you might consider: you could use a launcher script in the snap that inspects the path passed to the app, checks if it can be read, and offers a warning on stderr if snapctl is-connected removable-media returns false, pointing the user to connect the interface if the file is on a removable disk?
1 Like
Thanks reviewers for voting, +2 for, 0 against for auto-connection of personal-files interface and +2 for, 0 against for manual connection of removable-mediainterface to leaf snap, after publisher vetting.
If this is fine for you @mr_cal , I can start the publisher vetting process
Thanks for the suggestion. I’ve used similar hacks for other snaps and I think I’ll do something like this for Leaf too.
Yes, I’m fine with the results and proceeding on.
+2 for, 0 against granting personal-files interface to the above file to leaf snap. As @mr_cal is a canonical employee, Publisher is already vetted. This is now live
1 Like